-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(element): add one sweep element creation #109
Conversation
j-mendez
commented
Feb 26, 2023
- major performance improvements on element creation
@cfvescovo re-verted |
Maybe we could |
I like that, feel free to hop on the PR and make those changes or any, need to brb. |
src/node.rs
Outdated
} | ||
classes.extend(value.split_whitespace().map(LocalName::from)); | ||
id = Some(LocalName::from(a.value.deref())); | ||
} else if name_local == "class" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was rushing and made this change without thinking. @adamreichold @cfvescovo feel free to squash the commits for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thanks
I do not think I have permissions to edit this PR |
ok, ill make the changes really quick should be simple |
@cfvescovo updated |
@j-mendez thank you |